Weekly Dev Update #97

2021-07-12 — 6 min read

THORChain Weekly Dev Update for Week 97, 25 June — 02 July; Bitcoin Mempool Scanning, Ethereum Symbol Parse Errors and Exploit, MCCN updates 0.56.3, 0.57.2, 0.57.3, 0.57.4, 0.57.5, Community Updates

Summary

RAISETHECAPS

The caps were raised to 7m RUNE and filled. The continual Cap Raises give the protocol, middleware and interfaces more and more time to stabilise. Only when the system is stable throughout can the Caps be lifted. At this stage the target is 30m RUNE bonded and 15m RUNE pooled for the system to have caps lifted (this was the maximum seen on SCCN).

Bitcoin Mempool Scanning

~40mb of transactions was suddenly dumped into the Bitcoin mempool. This caused an overload on the Bitcoin block scanner and took out most of the Bitcoin Bifrosts on the network. The fix was to separate mempool scanning from block scanning.

https://gitlab.com/thorchain/thornode/-/merge_requests/1757

ETH Symbol Parsing Error (1)

A user deposited Maker (MKR) which suddenly caused all ETH Bifrosts to panic and halt. The network was halted for a bug fix to prevent loss of sync. The reason was that the Maker ERC20 is non-standard and returns bytes instead of a string for the memo.
https://gitlab.com/thorchain/thornode/-/merge_requests/1769

ETH Symbol Parsing Error (2)

A user successfully stole $140k from the network by exploiting a bug in ETH symbol parsing, where a fake ETH could be reported to the network.

This was covered here: ETH Parsing Error and Exploit

Fixed: https://gitlab.com/thorchain/thornode/-/merge_requests/1769

Updates

UPDATE 0.56.3

This is an emergency release to fix the issue on chaosnet right now which cause ETH chain doesn’t scan blocks
1. ETH block scan stopped due to fail to get symbol. PR: https://gitlab.com/thorchain/thornode/-/merge_requests/1771
2. Remove the trailing unicode point 0. PR: https://gitlab.com/thorchain/thornode/-/merge_requests/1775

UPDATE 0.57.2

This is an emergency release to fix the issue on chaosnet right now which attacker can use a malicious contract to attack the network , also carry all the changes in version 0.57.x

1) [BUG] When set-version , set-ip-address , set-node-key , the network take NativeTransactionFee from message signer. PR: https://gitlab.com/thorchain/thornode/-/merge_requests/1755
2) [BUG] Parallelise mempool scan for BTC/BCH/LTC. PR: https://gitlab.com/thorchain/thornode/-/merge_requests/1757
3) [ADD] Update ignore message on tx not matching format. PR: https://gitlab.com/thorchain/thornode/-/merge_requests/1759
4) [ADD] Allow bifrost to skip already signed TxOutItem. PR: https://gitlab.com/thorchain/thornode/-/merge_requests/1760
5) [ADD] Include synth supply in pool endpoints. PR: https://gitlab.com/thorchain/thornode/-/merge_requests/1764
6) [BUG] Check coin amount is not zero before sending between modules. PR: https://gitlab.com/thorchain/thornode/-/merge_requests/1768 , https://gitlab.com/thorchain/thornode/-/merge_requests/1765
7) [ADD] Update ETH scanner and library for 1.10.4 to support London fork. PR: https://gitlab.com/thorchain/thornode/-/merge_requests/1776
😍 [BUG] Fix the change that cause consensus failure. PR: https://gitlab.com/thorchain/thornode/-/merge_requests/1777
9) [BUG] Add executable permission to node-status.sh. PR: https://gitlab.com/thorchain/thornode/-/merge_requests/1778
10)[BUG] Fix ETH token parsing. PR: https://gitlab.com/thorchain/thornode/-/merge_requests/1783

release: https://gitlab.com/thorchain/thornode/-/tags/v0.57.0, https://gitlab.com/thorchain/thornode/-/tags/v0.57.1, https://gitlab.com/thorchain/thornode/-/tags/v0.57.2

UPDATE 0.57.3

1) [BUG] Bifrost identify outbound tx as already signed by mistake , thus refuse to sign it. PR: https://gitlab.com/thorchain/thornode/-/merge_requests/1785

Release: https://gitlab.com/thorchain/thornode/-/tags/v0.57.3

UPDATE 0.57.4

1) [BUG] Drop outbound tx that fail to broadcast to binance due to memo flag. PR: https://gitlab.com/thorchain/thornode/-/merge_requests/1790

UPDATE 0.57.5

Previous attempt to drop outbound tx that has memo flag might still cause more than 1/3 nodes get stucked with the transaction , this one will ignore the tx entirely
1) [BUG] Drop outbound tx that fail to broadcast to binance due to memo flag. PR: https://gitlab.com/thorchain/thornode/-/merge_requests/1794

Community Work

block42 Weekly Dev Report

Brokkr — Alpha version launched on testnet! — Synthetics can be tested on https://brokkr.finance/ — We’re currently working on incorporating feedback we’ve received; more is always welcome You can follow brokkr updates here: Twitter: @Brokkrfinance Telegram channel: https://t.me/brokkrfinance

TRX1’s Weekly Dev Report (21/06–27/06)

THORChain Monitoring bot — A new notification type added: “Mimir constant is modified” — “Trading halted/resumed” notification improvements — Added Rune price from Binance CEX to the price report — LP cap notification bug fix — Working on IL protection calculation for LP reports — Working on NodeOp tools menu Runiverse — Shader optimizations — Designing particle systems Miscellaneous — Helping to test the xchainpy_thornain library

RuneYield’s Weekly Dev Report (21/06–27/06)

iOS — Re-enabled fee earn information. Backend: — Created API document for all endpoint used in RuneYield.info (https://app.swaggerhub.com/apis-docs/bigboss4/RuneYield/1.0.0)

THORBelt Weekly Dev Report (June 21 to June 27)

— Added support for WalletConnect. Almost ready to be used, fixing one last issue with transaction signing — This opens the door for adding more native THORChain wallet support

Xchainpy Weekly Update (21/06–27/06)

— code refactor — release xchainpy-thorchain 0.2.0 to the pypi

Weekly Update (6/21–6/27)

— Guard against withdrawing from staged pools — Fixed small bug regarding XDEFI deposits — Simplify codebase for deposit form validation — added ViewBlock fallback link on Thorchain.net when users query native txs not picked up by Midgard — updated Network data on the explorer to reflect rewards / day instead of / block

GrassRoots Crypto Update

— All 3 Synths Videos now released, series complete — Part 3 Graphics uploaded to https://grassrootscrypto.io/defi/thorchain/thorfi/THORFI-Synths-Part-3/ — Planning next videos

THORSwap Update

— Added Ledger integration for THORChain — Fully integrated THORChain Synth — Updated mint/redeem/swap for synth trade — UI/UX improvements — THORName pre-order campaign

SKIPexchange Weekly Update (6/21–6/27):

— pool views UI/UX fixes — deposit/withdraw/swap waiting for confirmation from Midgard is added to update second tx hash if there is any and the assets amount — metamask connection support — xdefi/metamask deposit/send/withdraw bug fixes — working on asym deposit/withdraw options (dev side is done but UX is in progress) — working on other connection integrations (soon be added after tests)

Dragons’ Dex

— Weekly Dev Update • Connection to the Midgard API for retrieving THORChain pool data. • Connection to THORNodes for checking health and liquidity. • Minor improvements (sorting by value, RUNE price calculation).